Skip to content

Bugfix: Palette don't get exported to the right location

Sharaf Zaman requested to merge szaman/krita:bugfix-461579-cant-export-palettes into master

The bug is a regression from Krita 5.0.0. The bug surfaced in the commit: a2bb2433 which seems like a refactoring commit, where it was removed accidentally (maybe? @rempt ). Then the line was reverted back in 74eb1ffa along with other things to fix the issue. But the commit caused bugs unrelated to this issue so it had to be reverted and the line was back to what it was in a2bb2433.

I checked a few code paths where the function using the variable was used but there were a few too many to accurately verify. The tests still run like before, so I think it should be safe.

Test Plan

BUG:461579

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports