Skip to content

Spelling

Josh Soref requested to merge jsoref/krita:spelling into master

Hi, I'm not particularly comfortable using GitLab instances...

I've identified a number of tokens that look suspiciously like typos https://github.com/jsoref/krita/actions/runs/3466703214

I'm hoping to annotate this MR to identify interesting items, but I'm not sure I'll be able to, and it'll take a while.

Test Plan

I'm not sure, I'm pretty sure I've changed most of the system (including likely breaking localizations -- each project has a different approach to localizations, and I inevitably guess wrong when deciding whether/not to touch them).

I'm hoping to see a CI's report and address any complaints it may have, but, so far, I haven't encountered it.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
    • I'm really not in a position to do this. I was hoping to run into a CI and talk to it, but that hasn't made itself apparent.
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
    • Each commit should be individually stable / easily droppable.
    • Don't mix formatting changes with code changes -- In a couple of places the width of text changed, so I tried to update surrounding whitespace. I'd personally prefer not to do this, but it seems slightly better to do so.
    • Beyond that, the commit policy doesn't appear to offer any guidance. I could file a ticket for this if that's helpful. I think most of the guidance is designed for members as opposed to one-off contributors
  • I made sure my code conforms to the standards set in the HACKING file.
    • I read this file and don't think my changes are particularly impacted by it.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports