Skip to content

Fix transparency checkers on HDR

Agata Cacko requested to merge tymond/krita:tiar/fix_transparency_show_white_bug_407238_clean into master

First commit fixes transparency checkers (converts the image into color managed KisFixedPaintDevice with a correct display format). Second commit fixes the conversion of the background color (Dmitry said it should be that way, not using the display converter).

Test Plan

  • open any image with transparency on HDR display
  • open any image with transparency on Android device and non-HDR displays on all systems, since I removed some ifdefs
  • open any image and check if background color doesn't look terribly wrong
  • maybe set up background color to something very bright (in sRGB) and check if without my commit it would be super bright HDR?

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports