Skip to content

Test Clang-Tidy modernization

Amy spark requested to merge lsegovia/krita:work/amyspark/modernize-dll-load into master

This is a MR to evaluate the benefits of Clang-Tidy on Krita.

For this test, I decided to tackle some warnings related to QStringLiteral and FARPROC casting in main.cc.

And while at it, I decided to make the bits involving path concatenation in Windows more consistent.

Test Plan

Build and use Krita on Windows. There should be no semantic changes except for a cleaner bit of code.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports