Skip to content

Narrow horizontal layout for Brush Presets Docker (Second Attempt)

Narrow horizontal layout for Brush Presets Docker

Some users wanted to position the Brush Presets docker above the canvas to act like a toolbar. The standard vertical layout positions the brush tag filter and brush name filter above and below the brush presets view, creating wasted vertical space, when docking above the canvas. The horizontal layout by contrast positions the brush tag filter and brush name filter to the right of the brush presets view.

To enable the brush presets docker to perform the change from vertical to horizontal layout the underlying KisResourceItemChooser had to be modified. The switch from vertical to horizontal layout happens when the docker has height less than 100px (up for debate).

Test Plan

Go to Settings -> Docker -> Brush Presets detach the docker into a window and dock it above the canvas shrink the docker to less than 100px in height. HorizontalLayout2RowsFixed HorizontalLayout1RowFixed

Brush Presets Editor is now more responsive

The Brush Editor can now be resized, made fullscreen, minimized and the left and right panels can be resized once openned. test


  • KisPopupButton detached frame can now be resized;
  • KisTagChooserWidget no longer has it's minimum size tied to the length of it's contents see (this fixes the tagging bar being too long).

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

This is the second attempt after the first one was reverted due to bugs.

Edited by Măcelaru Tiberiu

Merge request reports