Skip to content

Ceddar/multilayer import fix

Cedric Ressler requested to merge ceddar/krita:ceddar/multilayer-import-fix into master
  • Changed kis_import_catcher.cc to import all layers of a given image to support OpenEXR Multilayer imports.
  • Changed the way the imported layer is named to keep layer names from OpenEXR Multilayer files or use filename if the layer would be called "Background" (default layer name when opening single layer images).
  • Changed kis_image_manager.cc importImage() to return the number of layers imported as stated in the functions description in kis_image_manager.h

Test Plan

  • Import OpenEXR Multilayer images (confirm naming is correct)
  • Import Tiff multilayer images
  • Import other multilayer images (if there are other formats)
  • Import single layer images such as PNG,JPEG (confirm naming is correct)

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
    Tests that failed were (all of which also fail before my commits):
    • libs-flake-TestSvgParser
    • libs-flake-TestSvgParserCloned
    • libs-flake-TestSvgParserRoundTrip
    • plugins-impex-KisHeifTest
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file. (I tried my best, but not 100% certain)
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by Cedric Ressler

Merge request reports