Skip to content

Add tilt X, Y to tablet tester

Joshua Goins requested to merge (removed):improve-tablet-tester into master

While testing plasma/kwin!3364 (merged) I realized that the only way to check if tilt works (reliably) is using the Tablet Debug Logger, which I didn't even know was a thing until I peeked at Krita's source code. This adds TX and TY to the tablet tester, which helps quite a bit:

image

(Don't mind that they are zero, I took the screenshot without my KWin patch but it does display actual values)

Not shown, but I also added some missing identifiers to the legend: including the new TX, TY and P (pressure).

Test Plan

Open up the tablet tester (ideally with tilt support) and make contact with the tablet screen.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports