Skip to content

RAW: enable use of upstream libkdcraw

Amy spark requested to merge lsegovia/krita:work/amyspark/libkdcraw-upstream into master

Continuing with my list of "longstanding grievances", this PR proposes the changes needed to use upstream libkdcraw again.

Only the widget code remains here; the read/writeSettings functions has been inline expanded, since those were removed from upstream. All other code was removed in favor of the upstream library, which has been added to 3rdparty and should now be built statically to avoid issues (i.e. ANDROID_EXTRA_LIBS).

ECM 5.76 is now required across all platforms; it was used only in Android, so I've updated patches accordingly.

Test Plan

Build Krita and try to import a RAW picture.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports