Skip to content

New Image widget cleanup

Amy spark requested to merge lsegovia/krita:work/amyspark/cleanup-new-image-widget into master

This PR is another try at cleaning up the layout of the New Image widget, favoring the use of the operating system's layout semantics.

Before After
Captura_de_pantalla_2022-12-27_132523 Captura_de_pantalla_2022-12-27_132705
Captura_de_pantalla_2022-12-27_132532 Captura_de_pantalla_2022-12-27_132719
Captura_de_pantalla_2022-12-27_132542 Captura_de_pantalla_2022-12-27_132727

The changes I've done are:

  • Switched the Image group box over to Form layout, and the combobox/spinbox pairs over to Grid layout (while ensuring the buddies are set up appropriately)
  • Switched the whole Image tab over to Form layout, and the "Save settings as" pair over to Grid layout (same as above)
  • Removed the duplicate padding off the WdgNewImage and Color Space Selector widgets, thus finally aligning the borders to the dialog container
  • Fixed misaligned Background and Description labels in the Contents tabs by switching them over to a groupbox
  • Fixed tabstops

Test Plan

Build Krita. Check, especially on Linux and macOS, that all widgets are rendered appropriately (in particular, they should not look chopped off).

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports