Skip to content

OpenGL: increase minimum to ES 3 / 4.1 core

Amy spark requested to merge lsegovia/krita:work/amyspark/update-opengl-minimum-version into master

This PR is a (possibly very controversial) proposal to update the minimum version of OpenGL and OpenGL ES that we allow in Krita.

Based on the fact that macOS either allows 2.1 or 4.1, no intermediate versions, and also no foreseeable updates, and that some SBCs only provide GL ES 2, I propose that we support:

  • 4.1 Core for macOS,
  • 4.1 Compatibility on desktops, this preserves existing semantics, and allows e.g. NVIDIA drivers to seamlessly offer the maximum available GL version
  • GL ES 3, and allow downgrade to ES 2

As with !1684 (merged), I'd meant to submit this with the VFX CY2021 changes last year, but they got clogged in the half float support.

Test Plan

Build Krita. Check that the accelerated canvas still renders correctly.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports