Skip to content

Show parsed TRC to advanced color space browser

Rasyuqa A H requested to merge rasyuqaa/krita:rasyuqaa/trc-advanced-colorspace-selecor into master

Now that we can parse transfer characteristics for ICC profiles, this MR proposed to display it correctly on the Advanced Color Space Browser tooltip. On simple gamma, the values are still displayed after TRC names, and on unspecified TRC without simple gamma (eg. LUT-based) the gamma values are not displayed instead of just 1,1,1.

Before After
tt-srgb-before tt-srgb-after
tt-gamma-before tt-gamma-after
tt-unspecified-before tt-unspecified-after

Test Plan

Build Krita, check if TRC tooltip from Color Space Browser returns a correct characteristics.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports