Skip to content

XCF: cleanup and update

Amy spark requested to merge lsegovia/krita:work/amyspark/xcftools-update into master

@dkazakov, this MR will incorporate a fix for a known CVE plus update xcftools to the latest version, 1.0.7. (It only adds static inline to some functions.)

I've also taken the time to port the configuration header, where relevant (because some flags are unused), and move the library itself to a separate static module to have the warning flags only affect it. Finally, I removed the Iconv module because there was no longer any use for it.

@szaman-- could you please test that this passes muster on Android? Since I've set the C standard to 11.

Test Plan

Build Krita.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports