Skip to content

KisAboutApplication: update and fix layout

Amy spark requested to merge lsegovia/krita:work/amyspark/kis-about-application into master

This MR proposes the following changes and fixes to KisAboutApplication:

  • Port its layout to a standalone UI widget + our Wdg self-layouting pattern
  • Port it to our KoDialog class
  • Fix the dialog being chopped half-way in the close button in Linux and macOS by applying KoDialog's minimum size management and margins
  • Remove the manual setup as much as possible in favor of the UI widget above and KoDialog's automated button management
  • Fix potential crashes with missing resources by following the QTextStream + split/join approach
    • this was done for 3rdparty pane only previously
    • it also allows for a more holistic management of the string pieces, we don't need to chop() lists' ends anymore
Before After
imagen imagen
imagen imagen

Test Plan

Build Krita and open the About... dialog.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports