Skip to content

KisToolSelectBase: add context arg to QTimer::singleShot

Mike Will requested to merge myqwil/krita:poly-select into master

This helps to ensure that the timer and KisToolSelectBase are both destroyed at the same time. Otherwise, the timer may potentially occur after the KisToolSelectBase has already been destroyed and cause Krita to crash.

Test Plan

  1. Open a document in Krita.
  2. Select either the Polygon Selection Tool or the Bezier Curve Selection Tool.
  3. Begin creating a selection, but leave it unfinished.
  4. With the selection still unfinished, close the document.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by Mike Will

Merge request reports