Skip to content

Boost: link against the imported Boost::boost target

Amy spark requested to merge lsegovia/krita:work/amyspark/cleanup-boost into master

include_directories pollutes the entirety of Krita with Boost's include directory. We can use the imported targets for that, while also patching them to ensure we don't link to any libraries.

Question: for extra sanity, should we increase the minimum version? 18.04 ships 1.65.1, and we use 1.80 across all OSes.

Test Plan

Build Krita.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports