Skip to content

ANGLE: assorted tidbits

Amy spark requested to merge lsegovia/krita:work/amyspark/googleangle into master

👋

This MR brings some small bits I noticed during the ANGLE build.

  • @dkazakov inserted a new patch during the migration to 5.15 that wasn't in sorted order nor in the correct folder.
  • the Qt version string wasn't updated.
  • the ANGLE libraries lacked version information, unlike those built with GN and shipped e.g. with Edge.

@alvinwong: I uploaded the missing changes here: https://github.com/alvinhochun/angle/compare/main...amyspark:angle:work/amyspark/for-krita-v5

Test Plan

Build ANGLE. Go to <deps install folder>/bin and right click in libEGL.dll and libGLESv2.dll. Check that both show the Git hash in their properties as follows:

imagen

imagen

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by Amy spark

Merge request reports