Skip to content

Fix python, sip, and pyqt build on macos

Ivan Yossi requested to merge ivany/krita:fix_python310 into master

With the recent merge of python 3.10 to master, our dependencies build broke (my fault since I never actually pushed the patches). The patches I used to compile 3.10.7 on macOS use pip install to get the binary libs from wheels. I used this as I could not make setup.py to find the correct egg version number of sip and refused to compile. This pip approach works without issues, and it seems there is no problem from a license point of view. However I'm not sure hence I make this MR.

It might also give use pip on the release dmg which it could in theory make python module a breeze to install into krita on macos. In practice it might be difficult because of codesign restrictions.

Changed to install sip and pyqt using pip3. In this form we do not compile our own libs but use the wheels libs from PyPI.

This is a first approach to have it working ASAP and seems to be license compatible with krita: https://www.riverbankcomputing.com/static/Docs/PyQt5/installation.html#installing-from-wheels

In the future it might be advised to avoid setup.py and use sip-build and sip-install scripts to compile pyqt on macos.

Edited by Ivan Yossi

Merge request reports