Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Krita Krita
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Bugzilla
    • Bugzilla
  • Merge requests 74
    • Merge requests 74
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • GraphicsGraphics
  • KritaKrita
  • Merge requests
  • !1721

main.cc: move temporary application logic

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mike Will requested to merge myqwil/krita:temp_app into master Jan 12, 2023
  • Overview 3
  • Commits 1
  • Pipelines 10
  • Changes 1

During startup, we create a temporary application to determine Krita's root path. However, on some systems, Krita crashes if we try to instantiate a QCoreApplication past the line of code that calls KisOpenGL::selectSurfaceConfig.

Test Plan

If Krita can load without crashing, that will mean the change was successful.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited Jan 12, 2023 by Mike Will
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: temp_app