Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Krita Krita
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Bugzilla
    • Bugzilla
  • Merge requests 74
    • Merge requests 74
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • GraphicsGraphics
  • KritaKrita
  • Merge requests
  • !1722

JPEG-XL: bump version to 0.8.1 and other improvements

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Rasyuqa A. H. requested to merge rasyuqaa/krita:rasyuqaa/jpegxl-more-improvements into master Jan 19, 2023
  • Overview 41
  • Commits 6
  • Pipelines 16
  • Changes 5

Been testing another round for JXL, so this MR have a few proposes:

Add option to store author profile data on export

Eg. just like when exporting to JPEG or PNG, I snip some code from JPEG export

jxl-sign-author-data

Move inverting filter only when doing CMYK export

Missed by me last time, now the inverting filter only called at CMYK images.

Workaround for 32-bit float modular lossy bug

Found some color artifact bug when exporting a lossy 32-bit float image with modular mode, already reported upstream. See: https://github.com/libjxl/libjxl/issues/2064

Bump libjxl version to 0.8.1 and highway to 1.0.2

libjxl 0.8.0 is out and it have some quality and speed improvement over 0.7.0, most notably the fast_lossless that finally implemented in effort 1 encoding, thus giving a massive speed boost:

Before After
070-e1-krita 080-e1-krita

Hopefully it'll be a painless update to 3rd party dependencies.
Edit: up to 0.8.1 for recent patch: https://github.com/libjxl/libjxl/releases/tag/v0.8.1

[Optional] Add preliminary ability to read/write special channel data

Moving this functionality for future branch / MR draft.

Test Plan

Build Krita, test JXL export/imports

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited Feb 06, 2023 by Rasyuqa A. H.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: rasyuqaa/jpegxl-more-improvements