Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Krita Krita
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Bugzilla
    • Bugzilla
  • Merge requests 74
    • Merge requests 74
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • GraphicsGraphics
  • KritaKrita
  • Merge requests
  • !1727

Draft: BUG:349152 | Create transform mask for clone and file layers when using transform tool

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Przemysław Gołąb (SirPigeonz) requested to merge pigeonz/krita:pigeonz/feature/auto-add-xform-mask into master Jan 28, 2023
  • Overview 8
  • Commits 2
  • Pipelines 6
  • Changes 3

Automatically adds and selects transform mask for clone and file layer when user attempts to use the tool on them.

The mask will be created only when user clicks the canvas, so no accidental masks will be creating by just selecting the tool while mentioned layers are active. Krita will also inform them with msg that those layers can't be transformed directly and that new mask for them was added. User has to click again after first click, which is not ideal but not sure how to go around that for now. Although, it doesn't create big problem for the user it's just less smooth.

Makes !510 obsolete.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited Jan 28, 2023 by Przemysław Gołąb (SirPigeonz)
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: pigeonz/feature/auto-add-xform-mask