Skip to content

Fix issue with loading resources of the "basic tools" plugin

Deif Lou requested to merge deiflou/krita:deiflou/fix_basic_tools_cursors into master

Now the "basic tools" pluging makes a static library that is then linked by the main dynamic library of the plugin. The resource file was added to the static library, but, according to Qt's documentation, using resources in a static library may need the explicit use of Q_INIT_RESOURCE in the code. The resources were not loaded/initialized and that caused that the relevant tool's cursors stopped working.

Instead of dealing with Q_INIT_RESOURCE, this patch simply adds the resources to the dynamic library instead of the static one in the cmake file.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Edited by Amy spark

Merge request reports