Skip to content

Fix TestSvgText.cpp compilation error

Mathias Wein requested to merge mwein/krita:text_test_compilation_fix into master

I'm not sure I analyzed this correctly, but from what I understand:

Since Raqm is added as target_linked_library(PRIVATE Raqm::Raqm) in libs/flake/CMakeLists.txt, it's include directory is not taken over to targets linking to kritaflake.

This causes TestSvgText.cpp to fail due to not finding raqm.h. Since it is only a "using" directive that's only used in KoSvgTextShape.cpp, I moved it there.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports