Skip to content

Show error message if backup file saving fails

Agata Cacko requested to merge tymond/krita:tiar/fix_bug465954_no_message_after_backup_file_fail into master

Before this commit, Krita wouldn't show an error message if the backup file saving procedure failed. This commit ensures the error message will be shown.

BUG:465954

Test Plan

A long, detailed procedure for bug testing is here: https://bugs.kde.org/show_bug.cgi?id=465954 However to test the changes without putting the newly compiled Krita in that file system, you can just move/save a .kra file there (successfully), then ensure there is no more space, and then try to save the file (with Backup File Location set to "The same folder as the file"). Then it will complain already at the backup file (if you set the backup file location to "User Folder", it will complain only later at the actual saving process, because the backup file was successful). Before the change, nothing would happen (only cue that the file is not saved would be the asterisk).

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by Amy spark

Merge request reports