Skip to content

3rdparty: port Find Modules away from LibFindMacros

Amy spark requested to merge lsegovia/krita:work/amyspark/remove-libfindmacros into master

Hi all,

In this MR I propose changes enabling us to drop the LibFindMacros module, which introduces additional noise on Windows due to it being unable to find pkgconf as well as certain CMake-only modules (primarily libde265).

I've moved all the affected Find Packages to a primary CMake lookup (if the package in 3rdparty supports it), adding the relevant namespacing and variable definitions to make naming compatible. Then I added and expanded the pkg-config fallbacks to enumerate all targets, so that other developers can copy our modules and use them without issues.

Test Plan

Build Krita with all dependencies from system or 3rdparty (it should work with both). Check that there are no linking issues. I tested here with Dmitry's llvm-mingw and my MSVC development environment.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports