Skip to content

Fix this month's Coverity entries

Amy spark requested to merge lsegovia/krita:work/amyspark/coverity-2 into master

Again nothing that's too concerning, except for two issues:

  • there was the non-zero chance of crashing ourselves with KisResourceResult because of a boost::bad_get exception leaking into the event loop
  • KIS_SAFE_ASSERT_RECOVER_BREAK was broken since b9f7132e (4.3) because the break applied to the macro'd while loop, not to the containing loop

Test Plan

Build Krita and run tests. There is no expected change in functionality except for fixed assertion breaks.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

/cc @woltherav

Merge request reports