Skip to content

Fix issue with toolbox background color

Freya Lupen requested to merge freyalupen/krita:freyalupen/toolbox-enablement into master

The KoToolBox::changeEvent() introduced in daa7cdf7 overrode QWidget::changeEvent()'s handling of the EnabledChange event, resulting in the enabled state and color not changing. Re-adding QWidget::changeEvent() to KoToolBox::changeEvent() seems to be the correct solution.

BUG:461126

Test Plan

  1. Have the Toolbox docker visible.
  2. Open/close documents, thus changing the docker's enabled state. Make sure the background color matches the enabled state (and the tool icons).

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by Amy spark

Merge request reports