Skip to content

More Coverity appeasement fixes

Amy spark requested to merge lsegovia/krita:work/amyspark/tiar-coverity-3 into master

Assorted Coverity fixes. There are more of those pass-by-value complaints involving ToolTransformArgs but they involve Dmitry's concurrency safety valve (lambdas going outside the scope of the callee).

Associated CID entries have already been marked as Fix Submitted and triaged.

Test Plan

Build and run Krita.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports