Skip to content

Android: Allow easier switching of the resource location

Sharaf Zaman requested to merge szaman/krita:android--resource-location-options into master

Previously, the only option we had is to press the default button and it would reset the resource location to a default one. In this implementation we add slightly more choices, for example showing an SD Card, Internal Storage and letting them choose a location manually.

image

Test Plan

Check if the behavior of the comboBox is as expected, and selecting something in the combobox does change resource location to the value.

The test APK: https://drive.google.com/file/d/1g3DWmbsfjcBvEw2kp86UIPvXiX4ERUAR/view?usp=share_link

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports