Skip to content

Video I/O dialog layout improvements

Amy spark requested to merge lsegovia/krita:work/amyspark/ffmpeg-2 into master

Hey @emmetoneill,

This is the promised PR to deal with the video import and export dialogs. Apart from the usual clang-tidy lint fixing, I focused on improving and simplifying the dialogs' layout and make them more accessible.

There's a new widget I made for the codec options dialog, KisStackedWidget, that enables a QStackedWidget to resize itself to its current visible member's sizeHint, instead of staying with the maximum of all children's sizes.

Video Import

Before After
before1 after1
before2 after2

Video Export

Before After
before_1 after_1_renewed
before_2 after_2
before_3 after_3
before_4 after_4

Test Plan

(Tell us how to test the changes you made.)

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports