Skip to content

Android: workaround multiple new files being created due to a race

Sharaf Zaman requested to merge szaman/krita:bug-creating-multiple-files into master

This seems like an issue with event loop, so whenever the document creation is successful, we accept the dialog (which should close it). But before the dialog is closed, we enable its "Ok" button, this allows makes it so the user can accidentally click it again and create multiple files.

In my case, it was very easy to create two or three files, if the user double taps, be it intentionally or accidentally.

The change moves the code so it is only activated if the image creation somehow fails (which from the commit message, seems to be the original purpose for enabling it).

Test Plan

Check if in case image creation fails, the 'Ok' button gets enabled.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports