Skip to content

Fix Transform Tool to update on arrow keys on Fast

Agata Cacko requested to merge tymond/krita:tiar/fix_bug457586_transform_tool_fast_not_updating_on_arrows into master

Before this commit, transform tool wouldn't update the canvas when the user used arrow keys to move the content using the Fast preview type.

BUG:457586

To do

[ ] - check why only Fast needed it, maybe there is a better patch that fixes this bug too

Test Plan

  1. Select Transform Tool, in the Tool Options select Fast preview, then try using arrow keys, possibly with Shift to see bigger impact. It should move.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports