Skip to content

Double supersampling factor when brush size is lower than 1 px

R. B. requested to merge tomtomtom/krita:tomtomtom/1pxsupersampling into master

BUG:453129

This commit doubles the typical supersampling factor from 3 to 6 when brush dabs are smaller than 1 px, in order to smooth out the dashed effect to nearly invisible levels.

Below demonstrates strokes from Ink-2 fineliner when max tablet speed is set to 5 m/s, at 100% zoom. Observe the differences in the centers of the strokes.

Without this change:

1

With this change (dashed effect no longer practically visible):

2

Notes:

  • A subtle dashed effect is still barely visible if the user zooms in quite a bit, though this might not matter for practical use cases. An even larger supersampling factor could be considered.
  • Some testing might be necessary.

Test Plan

Use brushes of sub-1 size or use brushes that utilize sub-1 size dabs from sensors.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by R. B.

Merge request reports