Skip to content

Move reference option for relevant tools to higher position

R. B. requested to merge tomtomtom/krita:tomtomtom/samplelayout into master

Inspired by https://github.com/LainFenrir/krita-tool-tweeks, this commit moves the reference option for the relevant tools to a higher position in the respective tool options, as a general user will tend to change this setting more often than the others. Their positions are described under Test Plan.

TODO: I'm not confident these are the ideal positions. It would probably be safest to just put them above Adjustments. I might ask for user feedback.

Test Plan

  • Select Fill tool. Check that Reference option is between Fill source and Fill extent.
  • Select Enclose-and-Fill tool. Check that Reference option is between Enclosing method and Target regions.
  • Select Contiguous Selection tool. Check that Reference option is between Action and Selection extent.
  • Select Similar Color Selection tool. Check that Reference option is between Action and Selection extent.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by R. B.

Merge request reports