Skip to content

Make Transform Tool work on multiple layers

Freya Lupen requested to merge freyalupen/krita:freyalupen/multilayer-transform into master

An attempt to let the Transform Tool work on multiple selected layers. It seems to work okay, but I'm not sure what cases to check for thorough testing, and doubtful about the code.

It works by checking if the selected layers are transformable and then adding them to the processedNodes list returned from KisTransformUtils::fetchNodesList(), which Group Layers use for transforming child layers. I'm not sure if that is a reasonable thing to do codewise.

There's a feature request for it here: https://krita-artists.org/t/ability-to-transform-multiple-layers-without-having-to-put-them-in-a-group-layer/3396

Test Plan

  1. Select multiple layers, and use the Transform Tool.
  2. Try to produce bugs?

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by Freya Lupen

Merge request reports