Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Krita Krita
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Bugzilla
    • Bugzilla
  • Merge requests 76
    • Merge requests 76
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • GraphicsGraphics
  • KritaKrita
  • Merge requests
  • !1802

Draft: Improve Bundle Creator in Krita

  • Review changes

  • Download
  • Patches
  • Plain diff
Open Srirupa Datta requested to merge srirupa/krita:srirupa/bundle_creator into master May 19, 2023
  • Overview 0
  • Commits 5
  • Pipelines 6
  • Changes 30

This MR has been created for GSoC'23 project - Improving the Bundle Creator.

Note the changes in the new Bundle Creator:

  • Side widget
  • Left section of the Choose Resources page is similar to Resource Manager.

Also note that nothing happens now when resource items are clicked.

demo2y

Update:

The Resource Chooser page has been completed.

Changes to be noted:

  • Can add resource items to the Selected table (click-to-add)
  • Remove selected resources from the table using Remove Selected button
  • Filter available resources by name or tag

demo3

Both the Enter Bundle Details page and Choose Save Location page have been completed.

bg2

Test Plan

  • Build and run Krita
  • Go to Settings > Manage Resources > Create a Bundle

The new bundle creator wizard has been created. The first, third and fourth wizard pages sharing common UI with resource manager has been designed partially.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited May 26, 2023 by Srirupa Datta
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: srirupa/bundle_creator