Skip to content

Improve Bundle Creator in Krita

Srirupa Datta requested to merge srirupa/krita:srirupa/bundle_creator into master

This MR has been created for GSoC'23 project - Improving the Bundle Creator.

Note the changes in the new Bundle Creator:

  • Side widget
  • Left section of the Choose Resources page is similar to Resource Manager.

Also note that nothing happens now when resource items are clicked.



The Resource Chooser page has been completed.

Changes to be noted:

  • Can add resource items to the Selected table (click-to-add)
  • Remove selected resources from the table using Remove Selected button
  • Filter available resources by name or tag


Both the Enter Bundle Details page and Choose Save Location page have been completed.

Update 2:

The Tool-button for switching between gridview and listview has been added. In order to keep the design consistent, I have changed all the icons' aspect ratio to Qt::IgnoreAspectRatio and have added a white background.


Update 3:

A small summary has been added to the last page, which provides an overview of the selected resources and tags. In this updated summary, the resource types are listed along with the corresponding counts. The selected tags are also listed. Additionally, this utilises the free space.

However it doesn't really look good, so I need to work on its appearance.


Test Plan

  • Build and run Krita
  • Go to Settings > Manage Resources > Create a Bundle

The new bundle creator wizard has been created. All the four wizard pages, and the class sharing common UI with resource manager has been designed. You can now create bundles with embedded tags, however no new features has been added to the Tag Chooser page, nor has its design been changed. This needs to be discussed.

Note: The horizontal scrolling should be implemented, else the entire text is not visible in Details view mode.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list,

Edited by Srirupa Datta

Merge request reports