Skip to content

Simplify XML parsing in KisPaintOpPreset and KisPropertiesConfiguration.

Quytelda Kahja requested to merge quytelda/krita:quytelda/qtxml into master

This merge request simplifies XML parsing code in KisPropertiesConfiguration::fromXML() and KisPaintOpPreset::loadFromDevice().

In both cases, we can traverse the XML document more succinctly using firstChildElement() and nextSiblingElement(). This eliminates the need to manually process QDomNodes and reduces complexity considerably.

This is the first patch I've submitted here, so let me know if there's any steps I've missed.

Test Plan

This MR doesn't implement any new functionality, so existing unit tests still apply. To manually test the changes, one can load a brush preset with embedded resources and verify all its properties are loaded correctly.

I tested the changes against both master and krita/5.1, and had good results with both.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports