Skip to content

Make transform shortcuts work on multiple layers

Freya Lupen requested to merge freyalupen/krita:freyalupen/multilayer-actions into master

This is an attempt to add support for transforming multiple selected layers with the layer transform actions (Mirror Layer Horizontally, etc).

Mirror, Rotate, Scale, Shear, and Offset Layers are now done.

BUG:470352

Test Plan

  1. Select multiple layers in a document.
  2. Use Layers->Transform->Mirror Layers Horizontally and Mirror Layers Vertically. All the selected layers or masks should be affected. The undo text should be plural in this case ('Mirror Layers X').
  3. Create a selection and use the Mirror actions, they should still work.
  4. Select a Group Layer, the actions should still work recursively.
  5. Same for all Rotate, Scale, Shear, and Offset Layers in the same menu.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by Freya Lupen

Merge request reports