Skip to content

Fix line tool with airbrush pixel engine brushes

Freya Lupen requested to merge freyalupen/krita:freyalupen/bug-447230 into master

Fix the Line Tool to consistently draw lines when using a pixel engine brush with the Airbrush option set. Other engines didn't have this problem because they don't use async updates. It seems that this regression was caused by removing doAsynchronousUpdate() in KisToolFreehandHelper::endPaint() in commit dcdef2ea, so I re-added it. I don't really know why it works or if there's a better way to fix it (probably?).

BUG:447230

Test Plan

Use a Pixel Engine brush with Airbrush set. Draw lines with the Line Tool. (Note that the airbrush option doesn't do anything for lines.)

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports