Skip to content

Fix Edit Shapes actions in multiple documents

Freya Lupen requested to merge freyalupen/krita:freyalupen/bug-467945 into master

The change point to corner/smooth/symmetric actions would only work on the most recently opened document, because they could only be part of one QActionGroup at a time. So remove the QActionGroup.

I don't know if it's okay to use the other connection syntax connect(m_actionPathPointCorner, &QAction::triggered, this, [this] { this->pointTypeChanged(KoPathPointTypeCommand::Corner); }); because it would be inconsistent, so I just created three pointTypeChanged functions instead.

BUG:467945

Test Plan

  1. Create a Vector Layer, draw a vector path on it.
  2. Open another document.
  3. In the first document, use the Edit Shapes Tool to change the type of a point on the path.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports