Skip to content

Add Kinetic scrolling to some widgets

Sharaf Zaman requested to merge szaman/krita:fixes-kinetic-scrolling into master

I added this since using scrollbar is very inconvenient on Android (and sometimes it exits the app, since scrollbars can be close to the screen edges).

Test Plan

The widgets I modified:

  • Undo Docker
  • Auto save recovery dialog
  • New File Dialog
  • Bundle manager
  • Configure Toolbars Dialog (On Android this makes drag and drop a bit difficult, but since double tapping moves the items to active/inactive this action isn't entirely disabled)

I also tried adding to KisDlgPreference, but since it is based on KPageDialog, it makes things a lot more difficult.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports