Skip to content

JPEG-XL: fix crashes when exporting layered with layer masks

Rasyuqa A H requested to merge rasyuqaa/krita:rasyuqaa/jpegxl-fix-crashes-with-layer-masks into master

(sorry for pushing the fixes granularly, I keep finding more bugs to squish during extensive testing... T-T)

I didn't realize that a layer with childCount() > 0 doesn't always mean a group layer.. it can be layers with layer masks. And if there are these kind of layers, the JXL layered export will crash. Got it fixed now and it rasterized / flattened properly.

Test Plan

  • Build Krita
  • Add layer mask to a layer (e.g. transparency / filter mask)
  • Export to JXL without flattening and verify that it properly exported and won't crash Krita.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports