Skip to content

Fix decimal font size in SvgTextEditor

Alvin Wong requested to merge alvinwong/krita:alvin/decimal-pointsize into master

Previously some code used QFont::pointSize() which returns the rounded integer value of the font size.

Test Plan

  1. Create some text.
  2. Set the font size to a decimal value (e.g. 9.5).
  3. Change the selection and verify the font size combobox shows the correct decimal font size.
  4. Switch to SVG source and verify the font-size property has the correct decimal font size.
  5. Switch back to rich text and verify the font size combobox shows the correct decimal font size.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports