Skip to content

Fix 'Don't show contents when moving sub-windows'

Freya Lupen requested to merge freyalupen/krita:freyalupen/bug-435348 into master

The checkbox didn't work because the value was never written. Instead, it always used the default value, based on whether Canvas Graphics Acceleration was enabled.

BUG:435348

Test Plan

  1. Under Preferences->General->Window, set Multiple Document Mode to Subwindows.
  2. Open a document and unmaximize it so it can be dragged around.
  3. Back in the window settings, under 'Subwindow mode' check and uncheck 'Don't show contents when moving sub-windows'. It should behave accordingly.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports