Skip to content

Fix Enclose Fill 'Stop growing at darkest pixel'

Freya Lupen requested to merge freyalupen/krita:freyalupen/enclosefill-typo into master

The button wouldn't work because the typo was fixed in the function name and not in the connection (because the connection was moved after the Spelling MR was made).

Test Plan

  1. Open a document, draw a shape.
  2. Select the Enclose and Fill tool, there shouldn't be a QObject::connect warning.
  3. Use the Enclose and Fill tool on the shape with the 'Stop growing at darkest pixel' button on and off, it should make some difference.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports