Fix build using system lib mypaint
While configuring the project, I would get the following errors:
CMake Error at cmake/modules/KritaAddBrokenUnitTest.cmake:61 (target_link_libraries):
Target "KisMyPaintOpTest" links to:
...
CMake Error at plugins/paintops/mypaint/CMakeLists.txt:26 (target_link_libraries):
Target "kritamypaintop_static" links to:
LibMyPaint::mypaint
but the target was not found. Possible reasons include:
* There is a typo in the target name.
* A find_package call is missing for an IMPORTED target.
* An ALIAS target is missing.
I discovered that the ALIAS target can be found in FindLibMyPaint.cmake
:
if (TARGET mypaint AND NOT TARGET LibMyPaint::mypaint)
add_library(LibMyPaint::mypaint ALIAS mypaint)
endif()
After replacing LibMyPaint::mypaint
with mypaint
, the project was able to complete the configuring process and build successfully.
EDIT: This change has been scrapped and replaced with a slightly altered version of 71296fbd
Formalities Checklist
-
I confirmed this builds. -
I confirmed Krita ran and the relevant functions work. -
I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!) -
I made sure my commits build individually and have good descriptions as per KDE guidelines. -
I made sure my code conforms to the standards set in the HACKING file. -
I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.