Skip to content

Decouple default SVG text styles from default QFont

Alvin Wong requested to merge alvinwong/krita:alvin/text-no-qfont-default into master

The old behaviour would skip writing font-family and font-size of text nodes that happens to match the default QFont. This would cause such files to follow the user-configurable Krita UI font, which doesn't make much sense.

Test Plan

  1. Create a text shape using the same font as the UI font
  2. Change to SVG editor
  3. Save the shape
  4. Close the text editor
  5. Edit the shape again
  6. Verify that font-family and font-size exists in the root text node

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports