Skip to content

svgtexttool: Fix modified state when switching editor mode

Alvin Wong requested to merge alvinwong/krita:alvin/svgtexttool-modified-state into master

This fixes a bug that saving the text after switching modes may not reset the modified state.

Test Plan

  1. Create a text shape
  2. Edit in rich text mode
  3. Switch to SVG mode
  4. Save the text
  5. Check that the "Discard" button is replaced with the "Close" button
  6. Do the reverse and check

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports