Skip to content

flake: Use more reliable way to check RTL from QTextDoc

Alvin Wong requested to merge alvinwong/krita:alvin/text-rtl-check into master

Use the text direction given by QTextBlock directly instead of reinventing the RTL detection. The old check is still kept as a backup, but probably won't be called.

CCBUG:392064

Test Plan

Input RTL text in the rich text editor and check that the generated svg use the same alignment as before.

(The render on canvas will probably look broken due to https://bugs.kde.org/show_bug.cgi?id=472382.)

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports