Skip to content

text: Add synthesizing italic and bold glyphs

Alvin Wong requested to merge alvinwong/krita:alvin/synthesize-italic into master

If the user requested italics and/or bold but the font does not have native italics and/or bold variants, 5.1 and earlier will synthesize oblique by shearing the glyphs, and bold by thickening the glyph outline. It is unclear what amount of shear Qt used.

Implement the same thing for the new text engine. A shear angle of 14 degrees is chosen to coincide with CSS's defaults. 1

This commit does not provide an option for disabling this behaviour. If such a switch is to be implemented in the future, it should probably use the CSS font-synthesis-style and font-synthesis-weight properties to do so. 2

BUG:465886

This MR is missing tests.

This MR now depends on !1876 (merged)

Test Plan

Create italic text with a font that does not have an italic variant.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by Alvin Wong

Merge request reports