Skip to content

Fix preset chooser resizing and scrolling issues

Freya Lupen requested to merge freyalupen/krita:freyalupen/fix-preset-list into master

This attempts to fix some regressions from MR!1670.

Make sure the 'responsive layout' (ability to switch to horizontal mode) is only enabled for the Brush Preset Docker that it's intended for, and that vertical layout is set when creating the widget and not later. Otherwise the toolbar Preset popup will noticeably resize itself when first opened. (CCBUG:463520)

Attempt to fix a regression with resource lists not being scrolled to active resource on first time by just calling scrollTo on resizeEvent. This also means the active resource is kept visible if the user resizes the list.

Both of these seem like they may be related to unnecessary resizes. There might be some other way to address the cause(s), then.

Test Plan

  1. Open the presets chooser on the toolbar. It shouldn't resize itself on first open. It should show the current preset.
  2. Open the brush editor; the preset sidebar, predefined brushtip, and pattern lists should show the current resource on first open and when resizing. Open a document to activate the Brush Preset Docker, and it should behave the same.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports